symbols-bar: optionally show labels and slightly tweak margins #8420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y tweak margins/height
|
I merged your other PR and now this one has conflicts for all the translations. |
|
Today I moved the toolbar to the same row as the menu bar, which Andrey kept requesting, and actually it feels pretty good. This is unfortunately inconsistent with this PR, since there's not really room for labels now. |
|
What would make sense with this PR would be that when labels are enabled, then the entire toolbar moves back to where it was. Fortunately, this is relatively easy/natural, since it's all in the title bar react component (just lightly change where the bar is rendered). |
haraldschilly
force-pushed
the
symbol-icons-configurable
branch
from
c803418 to
028c015
Compare
haraldschilly
force-pushed
the
symbol-icons-configurable
branch
from
028c015 to
8698c4b
Compare
…e fixes after merging
haraldschilly
force-pushed
the
symbol-icons-configurable
branch
from
a04fdf6 to
190a01b
Compare
|
I merged this since it's clearly way better than not having it. However, there are still 3 issues, which need to get addressed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This either renders just the icons next to the menu, and also adjusts the margin such that all the icons are aligned, see below:
I've also added a context menu for quick access. The setting below is still there as before merging this with upstream.
This is the setting:
And this is similar to before 1c54e48